[Bug 72779] New: Plancake composer dependancy

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72779

Bug ID: 72779
Summary: Plancake composer dependancy
Product: Wikimedia
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: Unprioritized
Component: Extension setup
Assignee: wikibugs-***@lists.wikimedia.org
Reporter: ***@reedyboy.net
CC: ***@gmail.com, ***@wikimedia.org,
***@espace-win.org, ***@gmail.com
Blocks: 69019
Web browser: ---
Mobile Platform: ---

We don't "need" to use the Plancake dependency, but the fact it's not just
regex probably suggests it might be better in the long run.

We don't have any support for composer stuff in production - we currently just
include the pre-prepared vendor repo for core for example.

So this needs a bit of work...

I'm wondering if we should just modify make-wmf-branch to look for
composer.json files, run "php composer.phar update --optimize-autoloader", and
then add the lot to the "Creating new wmf/1.XXwmfYY" branch commit?

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72779

--- Comment #1 from Sam Reed (reedy) <***@reedyboy.net> ---
It could go in mediawiki/vendor I guess... Considering vendor is primarly for
WMF usage (but others can use it for ease)

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72779

--- Comment #2 from Bryan Davis <***@wikimedia.org> ---
mediawiki/vendor is the right place to add composer managed dependencies that
are going to be used in WMF production. I wrote an RFC for it and everything.
:)
<https://www.mediawiki.org/wiki/Requests_for_comment/Composer_managed_libraries_for_use_on_WMF_cluster>

Working on making this better documented is part of the current "librarization"
project that Kunal, Aaron and I are working on.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72779

--- Comment #3 from Tony Thomas <***@gmail.com> ---
Should I prepare a patch adding plancake to
https://github.com/wikimedia/mediawiki-vendor/blob/master/composer.json and
committing the downloaded dependencies into the same repo ?

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72779

--- Comment #4 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 170369 had a related patch set uploaded by 01tonythomas:
Added the Plancake e-mail parser library to MediaWiki using Composer

https://gerrit.wikimedia.org/r/170369

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72779

Gerrit Notification Bot <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |PATCH_TO_REVIEW

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72779

Tony Thomas <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Blocks|69019 |

--- Comment #5 from Tony Thomas <***@gmail.com> ---
https://bugzilla.wikimedia.org/show_bug.cgi?id=69019#c6

This shouldn't be a blocker for our deployment right ?

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72779

--- Comment #6 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 170369 merged by jenkins-bot:
Added the Plancake e-mail parser library to MediaWiki using Composer

https://gerrit.wikimedia.org/r/170369

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72779

Bryan Davis <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|PATCH_TO_REVIEW |RESOLVED
Resolution|--- |FIXED